[PATCH] D66024: Name Demangling as specified in the Vector Function ABI

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 9 14:22:58 PDT 2019


lebedev.ri added a comment.

In D66024#1623711 <https://reviews.llvm.org/D66024#1623711>, @aranisumedh wrote:

> > All the parsing code is always extremely prone to subtle bugs.
> >  At least it should not crash on them.
> >  That would be easy to ensure via a fuzz target.
>
> Sorry for being naive here, but what is a fuzz target?


Oh, i should have clarified.
See e.g. `llvm/tools/llvm-dwarfdump/fuzzer/llvm-dwarfdump-fuzzer.cpp`, `llvm/tools/*-fuzzer`.

> I have also added several test cases to test for known corner cases.





================
Comment at: llvm/include/llvm/Analysis/SearchVectorFunctionSystem.h:29
+namespace llvm {
+
+/// Describes the type of Parameters
----------------
All these are currently in llvm namespace, would it be better to narrow it and put them into `VFABI`?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66024/new/

https://reviews.llvm.org/D66024





More information about the llvm-commits mailing list