[PATCH] D66023: Warning disable for mod-by-zero and union 'uninitialized' use

[Matthew G McGovern via Phabricator via llvm-commits]

mcgov created this revision.
mcgov added reviewers: rnk, vitalybuka, kubamracek.
mcgov added a project: Sanitizers.
Herald added a project: LLVM.
Herald added subscribers: llvm-commits, Sanitizers.

MSVC is throwing some warnings when compiling these sections (during a compile of asan_rt and llvm-symbolizer).

The uninitialized use warning is just an artifact of using a union, so I think we can safely ignore it. The mod-by-zero warning I'm less sure about, but unless someone with more knowledge about the code feels like this needs a fix I'd like to just disable the warning so we can build with warn-as-error and get past these.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D66023

Files:
  compiler-rt/lib/builtins/emutls.c
  compiler-rt/lib/builtins/fixunsxfdi.c
  compiler-rt/lib/builtins/fixunsxfsi.c
  compiler-rt/lib/builtins/fixxfdi.c
  compiler-rt/lib/builtins/udivmoddi4.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66023.214417.patch
Type: text/x-patch
Size: 3833 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190809/73354ae0/attachment.bin>