[PATCH] D66016: [DAGCombiner] exclude x*2.0 from normal negation profitability rules
Cameron McInally via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 9 11:26:35 PDT 2019
cameron.mcinally accepted this revision.
cameron.mcinally added a comment.
This revision is now accepted and ready to land.
LGTM. Less invasive is good.
But I do see value in not creating something just to immediately undo it. Option #2 would be similar to the special case in `SelectionDAGBuilder::visitFSub(...)`, which is also good.
I don't have a strong opinion either way...
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66016/new/
https://reviews.llvm.org/D66016
More information about the llvm-commits
mailing list