[PATCH] D65240: [XCOFF][AIX] Generate symbol table entries with llvm-readobj

Fri Aug 9 11:01:06 PDT 2019

jasonliu marked an inline comment as done.
jasonliu added inline comments.

================
Comment at: llvm/include/llvm/BinaryFormat/XCOFF.h:23
+enum {
+  NameSize = 8,
+  FileNamePadSize = 6
----------------
sfertile wrote:
> hubert.reinterpretcast wrote:
> > Please commit the removal of `SectionNameSize` and `SymbolNameSize` separately from this patch. This conflicts with other Phabricator reviews in flight.
> We should commit this as a NFC patch and then rebase this patch to reflect the change.
I was planning to land this first. Then when dust settles(https://reviews.llvm.org/D65159), have a NFC patch to remove those enums. 
In this way, we could have less dependencies. 
The more pedantic way is of course to land that NFC before this patch and D65159, then rebase these two patches. 
Have a slightly preference on my original plan because of less action on both end. 
But if you think it's better to land that NFC first, let me know and I could do that. 

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65240/new/

https://reviews.llvm.org/D65240