[PATCH] D56772: [MIR] Add simple PRE pass to MachineCSE

[Anton Afanasyev via Phabricator via llvm-commits]

anton-afanasyev added a comment.

Hi @LuoYuanke, I've benchmarked the effect of the revertion my and @lkail patches.
The benchmark showed some increase of the `exec_time`:

  ~/llvm/test-suite/utils/compare.py  --filter-short -m exec_time ~/llvm/test-suite-results/results_rel_base.json ~/llvm/test-suite-results/results_rel_base2.json vs ~/llvm/test-suite-results/results_rel_exp.json  ~/llvm/test-suite-results/results_rel_exp2.json 
  
  Program                                        lhs    rhs     diff 
   test-suite...Raw.test:BM_MULADDSUB_RAW/5001    13.96  17.35  24.3%
   test-suite...XRayFDRMultiThreaded/threads:4   568.16 634.38  11.7%
   test-suite...RayFDRMultiThreaded/threads:32   858.02 944.45  10.1%
   test-suite...XRayFDRMultiThreaded/threads:2   464.93 501.92   8.0%
   test-suite...algebra/kernels/symm/symm.test    14.00  15.12   7.9%
   test-suite...st:BM_BAND_LIN_EQ_LAMBDA/44217    39.41  37.34  -5.2%
   test-suite...test:BM_MULADDSUB_LAMBDA/44217   141.97 148.38   4.5%
   test-suite...Lambda.test:BM_EOS_LAMBDA/5001     9.88   9.48  -4.0%
   test-suite...ambda.test:BM_EOS_LAMBDA/44217    89.08  85.78  -3.7%
   test-suite...s/Halide/blur/halide_blur.test     1.77   1.83   3.6%
   test-suite...BenchmarkGame/Large/fasta.test     0.72   0.70  -3.3%
   test-suite...lcalsCRaw.test:BM_EOS_RAW/5001     9.86   9.54  -3.3%
   test-suite...calsCRaw.test:BM_EOS_RAW/44217    88.90  86.00  -3.3%
   test-suite...XRayFDRMultiThreaded/threads:8   983.92 1014.32  3.1%
   test-suite...RayFDRMultiThreaded/threads:16   979.55 1008.68  3.0%

So I'd like to leave these changes unreverted and to proceed with particular patches (like this one https://reviews.llvm.org/D63934). Please tell if you have any objections.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56772/new/

https://reviews.llvm.org/D56772