[PATCH] D64746: Add constrained intrinsics for lrint and lround

Kevin P. Neal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 9 09:26:24 PDT 2019


kpn updated this revision to Diff 214389.
kpn marked 5 inline comments as done.
kpn added a comment.
Herald added a subscriber: jdoerfert.

Address review comments.

I found that a minor tweak in ExpandArgFPLibCall() to mutate strict nodes makes the changes elsewhere much nicer and similar to the other library calls. I then moved the conversion to libcalls for lrint() and lround() into the ConvertNodeToLibCall() function. This patch should now be more in line with the traditional handling of library calls.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64746/new/

https://reviews.llvm.org/D64746

Files:
  docs/LangRef.rst
  include/llvm/CodeGen/ISDOpcodes.h
  include/llvm/CodeGen/SelectionDAGNodes.h
  include/llvm/CodeGen/TargetLowering.h
  include/llvm/IR/IntrinsicInst.h
  include/llvm/IR/Intrinsics.td
  include/llvm/Target/TargetSelectionDAG.td
  lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
  lib/CodeGen/SelectionDAG/SelectionDAG.cpp
  lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp
  lib/CodeGen/TargetLoweringBase.cpp
  lib/IR/IntrinsicInst.cpp
  lib/IR/Verifier.cpp
  test/CodeGen/X86/fp-intrinsics.ll
  test/Feature/fp-intrinsics.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64746.214389.patch
Type: text/x-patch
Size: 36819 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190809/16b6577a/attachment.bin>


More information about the llvm-commits mailing list