[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

Fri Aug 9 09:00:59 PDT 2019

andrew.w.kaylor added a comment.

In D62731#1623114 <https://reviews.llvm.org/D62731#1623114>, @mibintc wrote:

> @andrew.w.kaylor Thanks Andy.  Reminder -- in a private document you indicated to me that -fp-speculation=safe corresponds to the maytrap setting for the exception argument.  This patch is implemented with those semantics.

Right. This is a clear indication of why I shouldn't try to squeeze in a review just before heading out the door at the end of the day. The "separate option" in icc that I was referring to is -fp-speculation. Somehow I overlooked the fact that you were adding that option here. I saw your note and read the recent comments without looking over even the patch description. Sorry about that.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62731/new/

https://reviews.llvm.org/D62731