[PATCH] D66015: [llvm-strings] Improve testing of llvm-strings

[James Henderson via Phabricator via llvm-commits]

jhenderson created this revision.
jhenderson added reviewers: rupprecht, grimar, MaskRay, compnerd.
Herald added a project: LLVM.

This patch attempts to tidy up the llvm-strings testing by:

1. Adding comments to every test.
2. Getting rid of canned input files, and have the tests generate them on the fly (this makes the tests self-contained).
3. Adding missing test coverage.
4. Renaming some tests that weren't clear as to their purpose.
5. Adding extra checking of various cases, formatting etc.
6. Removing a test that didn't seem to have any useful purpose for testing llvm-strings.


Repository:
  rL LLVM

https://reviews.llvm.org/D66015

Files:
  test/tools/llvm-strings/Inputs/abcd
  test/tools/llvm-strings/Inputs/numbers
  test/tools/llvm-strings/Inputs/variable-length
  test/tools/llvm-strings/all-sections.test
  test/tools/llvm-strings/archive-filename.test
  test/tools/llvm-strings/eof-no-string.test
  test/tools/llvm-strings/eof.test
  test/tools/llvm-strings/file-filename.test
  test/tools/llvm-strings/help.test
  test/tools/llvm-strings/length.test
  test/tools/llvm-strings/multiple-inputs.test
  test/tools/llvm-strings/negative-char.test
  test/tools/llvm-strings/nested-archives.test
  test/tools/llvm-strings/option-grouping.test
  test/tools/llvm-strings/radix-filename.test
  test/tools/llvm-strings/radix.test
  test/tools/llvm-strings/response-file.test
  test/tools/llvm-strings/stdin-filename.test
  test/tools/llvm-strings/stdin.test
  test/tools/llvm-strings/terminator-neg.test
  test/tools/llvm-strings/terminator.test
  test/tools/llvm-strings/version.test
  test/tools/llvm-strings/whitespace.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66015.214381.patch
Type: text/x-patch
Size: 17934 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190809/e9d8c13a/attachment-0001.bin>