[PATCH] D66011: [llvm-readobj] - Remove 'error(Error EC)' helper.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 9 06:09:19 PDT 2019
grimar marked an inline comment as done.
grimar added inline comments.
================
Comment at: tools/llvm-readobj/llvm-readobj.cpp:385
void reportError(StringRef Input, Error Err) {
+ if (!Err)
----------------
MaskRay wrote:
> reportError now checks `if (!Err)`. Is it still appropriate to call it `reportError`? I want to hear other opinions.
Previously `error(Error EC)` did that. I can probably remove `if (!Err)` check to avoid the confusion.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66011/new/
https://reviews.llvm.org/D66011
More information about the llvm-commits
mailing list