[llvm] r368433 - [Mips][Codegen] Fix fast-isel mixing of FGR64 and AFGR64 registers
Simon Atanasyan via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 9 05:02:32 PDT 2019
Author: atanasyan
Date: Fri Aug 9 05:02:32 2019
New Revision: 368433
URL: http://llvm.org/viewvc/llvm-project?rev=368433&view=rev
Log:
[Mips][Codegen] Fix fast-isel mixing of FGR64 and AFGR64 registers
Fast-isel was picking AFGR64 register class for processing call
arguments when +fp64 options was used. We simply check is option +fp64
is used and pick appropriate register.
Patch by Mirko Brkusanin.
Differential Revision: https://reviews.llvm.org/D65886
Added:
llvm/trunk/test/CodeGen/Mips/copy-fp64.ll
Modified:
llvm/trunk/lib/Target/Mips/MipsFastISel.cpp
Modified: llvm/trunk/lib/Target/Mips/MipsFastISel.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsFastISel.cpp?rev=368433&r1=368432&r2=368433&view=diff
==============================================================================
--- llvm/trunk/lib/Target/Mips/MipsFastISel.cpp (original)
+++ llvm/trunk/lib/Target/Mips/MipsFastISel.cpp Fri Aug 9 05:02:32 2019
@@ -1162,14 +1162,20 @@ bool MipsFastISel::processCallArgs(CallL
if (ArgVT == MVT::f32) {
VA.convertToReg(Mips::F12);
} else if (ArgVT == MVT::f64) {
- VA.convertToReg(Mips::D6);
+ if (Subtarget->isFP64bit())
+ VA.convertToReg(Mips::D6_64);
+ else
+ VA.convertToReg(Mips::D6);
}
} else if (i == 1) {
if ((firstMVT == MVT::f32) || (firstMVT == MVT::f64)) {
if (ArgVT == MVT::f32) {
VA.convertToReg(Mips::F14);
} else if (ArgVT == MVT::f64) {
- VA.convertToReg(Mips::D7);
+ if (Subtarget->isFP64bit())
+ VA.convertToReg(Mips::D7_64);
+ else
+ VA.convertToReg(Mips::D7);
}
}
}
Added: llvm/trunk/test/CodeGen/Mips/copy-fp64.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Mips/copy-fp64.ll?rev=368433&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/Mips/copy-fp64.ll (added)
+++ llvm/trunk/test/CodeGen/Mips/copy-fp64.ll Fri Aug 9 05:02:32 2019
@@ -0,0 +1,29 @@
+; NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+
+; RUN: llc -march=mips -mcpu=mips32r2 -O0 -relocation-model=pic -mattr=+fp64 \
+; RUN: -stop-before=prologepilog %s -o - | FileCheck %s
+
+declare double @bar(double)
+
+define double @foo(double %self) {
+ ; CHECK-LABEL: name: foo
+ ; CHECK: bb.0.start:
+ ; CHECK: successors: %bb.1(0x80000000)
+ ; CHECK: liveins: $d12_64, $t9, $v0
+ ; CHECK: renamable $at = ADDu killed $v0, killed $t9
+ ; CHECK: ADJCALLSTACKDOWN 16, 0, implicit-def $sp, implicit $sp
+ ; CHECK: $d6_64 = COPY killed renamable $d12_64
+ ; CHECK: renamable $t9 = LW killed renamable $at, target-flags(mips-got) @bar
+ ; CHECK: dead $ra = JALR killed $t9, csr_o32_fp64, target-flags(mips-jalr) <mcsymbol bar>, implicit-def dead $ra, implicit killed $d6_64, implicit-def $d0_64
+ ; CHECK: ADJCALLSTACKUP 16, 0, implicit-def $sp, implicit $sp
+ ; CHECK: SDC164 killed $d0_64, %stack.0, 0 :: (store 8 into %stack.0)
+ ; CHECK: bb.1.bb1:
+ ; CHECK: $d0_64 = LDC164 %stack.0, 0 :: (load 8 from %stack.0)
+ ; CHECK: RetRA implicit killed $d0_64
+start:
+ %0 = call double @bar(double %self)
+ br label %bb1
+
+bb1:
+ ret double %0
+}
More information about the llvm-commits
mailing list