[PATCH] D64753: [CrossTU][NFCI] Refactor loadExternalAST function

Balázs Kéri via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 9 04:13:38 PDT 2019


balazske added a comment.

I discovered that there are problems with this change. The number of loaded AST units is not incremented correctly and the "CTU loaded AST file" is displayed for every access to a AST unit (even if it was got from cache). The problem is that the counting and print of AST loads does not handle the case when the load returned a cached result (and no real loading happened). This causes "annoying" messages and the AST unit limit is not handled correctly.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64753/new/

https://reviews.llvm.org/D64753





More information about the llvm-commits mailing list