[llvm] r368401 - [InstSimplify] Report "Changed" also when only deleting dead instructions

[Bjorn Pettersson via llvm-commits]

Author: bjope
Date: Fri Aug  9 00:08:25 2019
New Revision: 368401

URL: http://llvm.org/viewvc/llvm-project?rev=368401&view=rev
Log:
[InstSimplify] Report "Changed" also when only deleting dead instructions

Summary:
Make sure that we report that changes has been made
by InstSimplify also in situations when only trivially
dead instructions has been removed. If for example a call
is removed the call graph must be updated.

Bug seem to have been introduced by llvm-svn r367173
(commit 02b9e45a7e4b81), since the code in question
was rewritten in that commit.

Reviewers: spatel, chandlerc, foad

Reviewed By: spatel

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D65973

Added:
    llvm/trunk/test/Transforms/InstSimplify/remove-dead-call.ll   (with props)
Modified:
    llvm/trunk/lib/Transforms/Scalar/InstSimplifyPass.cpp

Modified: llvm/trunk/lib/Transforms/Scalar/InstSimplifyPass.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/InstSimplifyPass.cpp?rev=368401&r1=368400&r2=368401&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/InstSimplifyPass.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/InstSimplifyPass.cpp Fri Aug  9 00:08:25 2019
@@ -45,6 +45,7 @@ static bool runImpl(Function &F, const S
         // Don't waste time simplifying dead/unused instructions.
         if (isInstructionTriviallyDead(&I)) {
           DeadInstsInBB.push_back(&I);
+          Changed = true;
         } else if (!I.use_empty()) {
           if (Value *V = SimplifyInstruction(&I, SQ, ORE)) {
             // Mark all uses for resimplification next time round the loop.

Added: llvm/trunk/test/Transforms/InstSimplify/remove-dead-call.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstSimplify/remove-dead-call.ll?rev=368401&view=auto
==============================================================================
--- llvm/trunk/test/Transforms/InstSimplify/remove-dead-call.ll (added)
+++ llvm/trunk/test/Transforms/InstSimplify/remove-dead-call.ll Fri Aug  9 00:08:25 2019
@@ -0,0 +1,28 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -instsimplify -S -o /dev/null -debug-pass=Details 2>&1 | FileCheck --check-prefix DETAILS %s
+; RUN: opt < %s -instsimplify -S -o - | FileCheck %s
+
+; Verify that InstSimplifyLegacyPass notifies the pass manager about changes
+; being made (when a call is removed CGSCC must be updated).
+;
+; DETAILS: Made Modification 'Remove redundant instructions' on Function 'main'
+
+define internal void @func_1(i64* nocapture readnone %0) #0 {
+; CHECK-LABEL: @func_1(
+; CHECK-NEXT:    unreachable
+;
+  unreachable
+}
+
+define i16 @main(i16 %0, i16** nocapture readnone %1) #1 {
+; CHECK-LABEL: @main(
+; CHECK-NEXT:  bb1:
+; CHECK-NEXT:    unreachable
+;
+bb1:
+  call void @func_1(i64* undef)
+  unreachable
+}
+
+attributes #0 = { noinline norecurse nounwind readnone }
+attributes #1 = { norecurse nounwind readnone }

Propchange: llvm/trunk/test/Transforms/InstSimplify/remove-dead-call.ll
------------------------------------------------------------------------------
    svn:executable = *