[llvm] r368397 - [X86] Remove stale FIXME from combineMaskedStore. NFC
Craig Topper via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 8 22:55:41 PDT 2019
Author: ctopper
Date: Thu Aug 8 22:55:41 2019
New Revision: 368397
URL: http://llvm.org/viewvc/llvm-project?rev=368397&view=rev
Log:
[X86] Remove stale FIXME from combineMaskedStore. NFC
I believe PR34584 was tracking that FIXME, but its since been
closed and a test case was added.
Modified:
llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=368397&r1=368396&r2=368397&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Thu Aug 8 22:55:41 2019
@@ -39760,10 +39760,6 @@ static SDValue combineMaskedStore(SDNode
return SDValue(N, 0);
}
- // TODO: AVX512 targets should also be able to simplify something like the
- // pattern above, but that pattern will be different. It will either need to
- // match setcc more generally or match PCMPGTM later (in tablegen?).
-
SDValue Value = Mst->getValue();
if (Value.getOpcode() == ISD::TRUNCATE && Value.getNode()->hasOneUse() &&
TLI.isTruncStoreLegal(Value.getOperand(0).getValueType(),
More information about the llvm-commits
mailing list