[PATCH] D65367: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 2]

Alex Brachet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 8 22:45:56 PDT 2019


abrachet marked 4 inline comments as done.
abrachet added a comment.

In D65367#1621113 <https://reviews.llvm.org/D65367#1621113>, @jhenderson wrote:

> I don't think you want to be modifying the number of dynamic symbols at all. That would require you to make other changes to loadable code, which would impact addresses, and effectively require you to completely relink the program.
>
> You may however still need to modify the contents of the existing dynamic symbols (specifically you may need to be able to update their section indexes).


Ok I can just not add an `addDynSymbol` and `removeDynSymbol` methods then.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65367/new/

https://reviews.llvm.org/D65367





More information about the llvm-commits mailing list