[PATCH] D65795: [TargetLowering] Remove optional arguments passing to makeLibCall

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: include/llvm/CodeGen/TargetLowering.h:3547
 
+  struct makeLibCallOptions {
+    ArgListEntry Entry;
----------------
LLVM standard style is that all type names are capitalized.


================
Comment at: include/llvm/CodeGen/TargetLowering.h:3549
+    ArgListEntry Entry;
+    CallLoweringInfo CLI;
+
----------------
Does it really make sense to have these two big structs here, when makeLibCall itself only uses a few bits from them?


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:2478
+  CallOptions.Entry.IsSExt = CallOptions.CLI.RetSExt = true;
+  SplitInteger(TLI.makeLibCall(DAG, LC, VT, Op, CallOptions/*irrelevant*/, dl).first,
                Lo, Hi);
----------------
The "irrelevant" is supposed to be attached to whether the result is signed; an integer that's too large to fit in a register probably isn't going to get extended on any target.

It isn't really a useful comment, though; I'd just get rid of it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65795/new/

https://reviews.llvm.org/D65795