[PATCH] D65980: [WebAssembly][lld] control __data_end export with config->shared

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 8 15:35:42 PDT 2019


sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.

  Great thanks.  Sorry I overlooked that in my last change.   Ideally we shouldn't be making this available in `-pie` either but for restoring the previous behaviour seems reasonable.



================
Comment at: lld/wasm/Driver.cpp:530
 
-  if (!config->isPic) {
+  if (!config->shared) {
     WasmSym::dataEnd = symtab->addOptionalDataSymbol("__data_end");
----------------
Remove the curlies


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65980/new/

https://reviews.llvm.org/D65980





More information about the llvm-commits mailing list