[PATCH] D65973: [InstSimplify] Report "Changed" also when only deleting dead instructions

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 8 14:28:57 PDT 2019


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM.

I stepped through this example, and wouldInstructionBeTriviallyDead() returns true because the call has neither uses nor side effects. So we mark it as dead, and then it gets deleted. I'm not sure if that explains the other bug reports mentioned in D65336 <https://reviews.llvm.org/D65336> though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65973/new/

https://reviews.llvm.org/D65973





More information about the llvm-commits mailing list