[PATCH] D65697: [lit] Fix internal env calling internal commands
Joel E. Denny via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 8 12:14:29 PDT 2019
jdenny added a comment.
In D65697#1621615 <https://reviews.llvm.org/D65697#1621615>, @probinson wrote:
> Those files under fake-externals... are those symlinks? IIUC that doesn't work so well on Windows. I admit I haven't tried downloading your patch to verify.
Yes, they are. I don't use Windows enough to know. I could probably just do something like a python import instead.
By the way, would it be better to separate that fake-externals stuff into another patch?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65697/new/
https://reviews.llvm.org/D65697
More information about the llvm-commits
mailing list