[PATCH] D65464: [LoopFusion] Add ability to fuse guarded loops

[Kit Barton via Phabricator via llvm-commits]

kbarton marked an inline comment as done.
kbarton added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopFuse.cpp:257
+
+  bool isRotated() const {
+    assert(L && "Expecting loop to be valid.");
----------------
Whitney wrote:
> I am thinking if we should have this function in Loop class.
Good idea.
I've created https://reviews.llvm.org/D65958 to add this.
Once it lands, I can update this code to use the new method in the loop class (that can be done independent of this review, IMO). 


================
Comment at: llvm/lib/Transforms/Scalar/LoopFuse.cpp:1570
+
+    FuseCounter++;
+
----------------
Whitney wrote:
> reportLoopFusion<OptimizationRemark>(*FC0, *FC1, FuseCounter);
This was actually a mistake. It is counted in the main loop and should not be counted here. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65464/new/

https://reviews.llvm.org/D65464