[PATCH] D65922: [lld][WebAssembly] Allow linking of PIC code into static binaries

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 8 11:20:48 PDT 2019


dschuff added inline comments.


================
Comment at: lld/wasm/Driver.cpp:541
     WasmSym::heapBase = symtab->addOptionalDataSymbol("__heap_base");
+    WasmSym::definedMemoryBase = symtab->addOptionalDataSymbol("__memory_base");
+    WasmSym::definedTableBase = symtab->addOptionalDataSymbol("__table_base");
----------------
does this mean we create these symbols in the output even when not linking PIC code?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65922/new/

https://reviews.llvm.org/D65922





More information about the llvm-commits mailing list