[PATCH] D65914: [Dwarf] DW_TAG_unspecified_type is a type tag.

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

In D65914#1621471 <https://reviews.llvm.org/D65914#1621471>, @aprantl wrote:

> In D65914#1621427 <https://reviews.llvm.org/D65914#1621427>, @probinson wrote:
>
> > In D65914#1621248 <https://reviews.llvm.org/D65914#1621248>, @aprantl wrote:
> >
> > > FYI. You can derive the complete list by scanning for DW_AT_type in DWARF 5 Appendix A, Table A.1.
> >
> >
> > ? not really.  Any tag that is a type qualifier will have DW_AT_type, but also anything else that simply has a type (DW_TAG_constant, etc).
> >
> > I do think that the regex DW_TAG_*_type will find all of them.
>
>
> I'm probably misunderstanding something here, but DW_TAG_constant *is* listed in Appendix A as allowing a DW_AT_type attribute, so are all the DW_TAG_*_type tags.


is-a versus has-a?  We want the `isType(Tag T)` predicate to return true for the tags that DW_AT_type is allowed to *point to* (i.e. whether the tag is-a type), not those tags that permit DW_AT_type as an attribute (i.e., those that have-a type).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65914/new/

https://reviews.llvm.org/D65914