[PATCH] D65673: [MBP] Disable aggressive loop rotate in plain mode

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:2054
+MachineBasicBlock *
+MachineBlockPlacement::findBestLoopTopPlain(
+    const MachineLoop &L,
----------------
Can this be merged with findBestLoopTop with some refactoring?


================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:2545
   bool RotateLoopWithProfile =
-      ForcePreciseRotationCost ||
-      (PreciseRotationCost && F->getFunction().hasProfileData());
+      ForcePreciseRotationCost || F->getFunction().hasProfileData();
 
----------------
Does this change also turn on PreciseRotationCost by default? I don't think this is intended.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65673/new/

https://reviews.llvm.org/D65673