[PATCH] D64825: Enable assembly output of local commons for AIX

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 8 07:02:14 PDT 2019


sfertile accepted this revision.
sfertile added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/MC/MCSectionXCOFF.cpp:34
+        getMappingClass() != XCOFF::XMC_BS)
+      llvm_unreachable("Generated a storage-mapping class for a common/bss "
+                       "csect we don't understand how to switch to.");
----------------
minor nit: I think we could shorten `common/bss` -->  '.bss' .


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64825/new/

https://reviews.llvm.org/D64825





More information about the llvm-commits mailing list