[llvm] r368253 - Revert "Temporarily bump minimum compiler version"

JF Bastien via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 8 06:33:08 PDT 2019



> On Aug 7, 2019, at 11:22 PM, David Zarzycki <dave at znu.io> wrote:
> 
> Food for thought: there probably is a correlation between bot speed and software versions. If you really want to smoke out older compiler usage, you’re going to have to wait 8+ hours for the slower bots (which could easily have older OS with older compilers because they were setup long ago).

Maybe! I figured that this time of day (when nobody commits) would give me a lot of the bots. 

Otherwise I looked through the bots’ own declared compiler version and it’s a mess (just like last time I looked) :-(


>> On Aug 8, 2019, at 6:48 AM, JF Bastien via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>> 
>> Author: jfb
>> Date: Wed Aug  7 22:47:59 2019
>> New Revision: 368253
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=368253&view=rev
>> Log:
>> Revert "Temporarily bump minimum compiler version"
>> 
>> It's been in for more than 30 min and no bots have complained. Let's see if some
>> slow ones catch up. I'll do another manual pass on bots later (in case some that
>> were down are back up), and then turn this on permanently through a regular
>> review.
>> 
>> Modified:
>>   llvm/trunk/cmake/modules/CheckCompilerVersion.cmake
>> 
>> Modified: llvm/trunk/cmake/modules/CheckCompilerVersion.cmake
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/CheckCompilerVersion.cmake?rev=368253&r1=368252&r2=368253&view=diff
>> ==============================================================================
>> --- llvm/trunk/cmake/modules/CheckCompilerVersion.cmake (original)
>> +++ llvm/trunk/cmake/modules/CheckCompilerVersion.cmake Wed Aug  7 22:47:59 2019
>> @@ -4,11 +4,11 @@
>> 
>> include(CheckCXXSourceCompiles)
>> 
>> -set(GCC_MIN 5.1)
>> +set(GCC_MIN 4.8)
>> set(GCC_SOFT_ERROR 5.1)
>> -set(CLANG_MIN 3.5)
>> +set(CLANG_MIN 3.1)
>> set(CLANG_SOFT_ERROR 3.5)
>> -set(APPLECLANG_MIN 6.0)
>> +set(APPLECLANG_MIN 3.1)
>> set(APPLECLANG_SOFT_ERROR 6.0)
>> 
>> # https://en.wikipedia.org/wiki/Microsoft_Visual_C#Internal_version_numbering
>> @@ -17,7 +17,7 @@ set(MSVC_MIN 19.1)
>> set(MSVC_SOFT_ERROR 19.1)
>> 
>> # Map the above GCC versions to dates: https://gcc.gnu.org/develop.html#timeline
>> -set(GCC_MIN_DATE 20150422)
>> +set(GCC_MIN_DATE 20130322)
>> set(GCC_SOFT_ERROR_DATE 20150422)
>> 
>> 
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> 


More information about the llvm-commits mailing list