[PATCH] D65903: [LLD] [COFF] Allow using custom .edata from input object files

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D65903#1620642 <https://reviews.llvm.org/D65903#1620642>, @ruiu wrote:

> I agree with you that this implementation is straightforward and simple, and I'm fine to add this if changing wine is not easy.


We discussed it with the Wine maintainer already, and he preferred this approach over using export directives.

> Could you add a little bit of comment to the code to explain what this is for?

Sure, I can do that.

> Do you think it makes sense to show a warning if both `-export` and `.edata` are used?

That would probably make sense. Unfortunately, I think we only know whether we have custom .edata at the end, after we've autoexported all symbols (if no export directives were found), but I can store a bool to distinguish between the cases.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65903/new/

https://reviews.llvm.org/D65903