[PATCH] D65934: [ORC] FIxed warning on Windows about deprecated ORCv1

Ivan Karachun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 8 03:08:01 PDT 2019


ivankara created this revision.
ivankara added reviewers: lhames, sgraenitz, AlexDenisov, dblaikie.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.

Building with MSVC 2017 there was a warning raised about deprecated ORCv1.
Turned out that there was a missing 'AcknowledgeORCv1Deprecation' parameter in `emplace_back` call.


Repository:
  rL LLVM

https://reviews.llvm.org/D65934

Files:
  llvm/lib/ExecutionEngine/Orc/OrcCBindingsStack.h


Index: llvm/lib/ExecutionEngine/Orc/OrcCBindingsStack.h
===================================================================
--- llvm/lib/ExecutionEngine/Orc/OrcCBindingsStack.h
+++ llvm/lib/ExecutionEngine/Orc/OrcCBindingsStack.h
@@ -316,7 +316,7 @@
     if (auto Err = CtorRunner.runViaLayer(*this))
       return std::move(Err);
 
-    IRStaticDestructorRunners.emplace_back(std::move(DtorNames), K);
+    IRStaticDestructorRunners.emplace_back(AcknowledgeORCv1Deprecation, std::move(DtorNames), K);
 
     return K;
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65934.214094.patch
Type: text/x-patch
Size: 524 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190808/cb5f42a3/attachment.bin>


More information about the llvm-commits mailing list