[PATCH] D65922: [lld][WebAssembly] Allow linking of PIC code into static binaries

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 8 00:53:15 PDT 2019


ruiu added inline comments.


================
Comment at: lld/wasm/Relocations.cpp:43
 
+static void addGOTEntry(Symbol* sym) {
+  // In PIC mode a GOT entry is an imported global that the dynamic linker
----------------
nit: space not after but before `*` 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65922/new/

https://reviews.llvm.org/D65922





More information about the llvm-commits mailing list