[PATCH] D65799: [yaml2obj/obj2yaml][MachO] Allow setting custom section data
Alexander Shaposhnikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 7 22:41:56 PDT 2019
alexshap added inline comments.
================
Comment at: llvm/include/llvm/ObjectYAML/MachOYAML.h:203
static void mapping(IO &IO, MachOYAML::Section &Section);
+ static StringRef validate(IO &io, MachOYAML::Section &Section);
};
----------------
khm, to be honest, I would not place it here , these template specializations provide the static method "mapping" only. Somehow, I don't see where this method ("validate") is being used at the moment - maybe we can either delete it or hide it inside MachOYAML.cpp
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65799/new/
https://reviews.llvm.org/D65799
More information about the llvm-commits
mailing list