[PATCH] D65191: [llvm-objdump] Implement highlighting

[Seiya Nuta via Phabricator via llvm-commits]

seiya marked an inline comment as done.
seiya added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:2288
 
+  ColorsEnabled = WithColor::colorsAvailable(outs());
+
----------------
@MaskRay I've splitted WithColor::colorsEnabled into colorsEnabled and colorsAvailable again. Do you think I should do `(UseColor == cl::BOU_UNSET && OS.has_colors()) || UseColor == cl::BOU_TRUE` here instead? I wonder if keeping UseColor static is better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65191/new/

https://reviews.llvm.org/D65191