[PATCH] D63741: [TableGen] Add "InitValue": Handle operands with set bit values in decoder methods

[Daniel Sanders via Phabricator via llvm-commits]

dsanders added inline comments.


================
Comment at: test/TableGen/FixedLenDecoderEmitter/InitValue.td:11
+
+let OutOperandList = (outs), Size = 2 in {
+
----------------
nlguillemot wrote:
> nlguillemot wrote:
> > dsanders wrote:
> > > This is a bit confusing and isn't really doing anything helpful. For this test case, I'd prefer to just have the lets duplicated inside the defs.
> > > 
> > > Also, the formatting in this file isn't following the conventions used by most tablegen files (e.g. closing } being in the same column as the 'd' from def)
> > The formatting is copy/pasted from `test/TableGen/BitOffsetDecoder.td`, so that's my "claim of innocence". Of course we could change it anyways, and clean up `BitOffsetDecoder.td` as well in a separate patch. Thoughts?
> ping - what would you like to do?
I'd prefer it to be formatted in the conventional way but since the same formatting is used elsewhere it's ok to keep it as-is


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63741/new/

https://reviews.llvm.org/D63741