[PATCH] D65882: [LLD][ELF][AArch64] Support for movz, movk tprel relocations

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Looks good to me. Some nits of the test:



================
Comment at: test/ELF/aarch64-movw-tprel.s:27
+## TCB + 0 == 16
+# CHECK:  210000: 00 02 80 d2                   mov     x0, #16
+
----------------
The address can be omitted. The encoding bytes may be omitted, too (`--no-show-raw-insn`).

Probably make all instruction `CHECK:` lines `CHECK-NEXT:`. I think they are contiguous.


================
Comment at: test/ELF/aarch64-movw-tprel.s:40
+
+# CHECK-SYM:      Name: v1
+# CHECK-SYM-NEXT: Value: 0x10000
----------------
(Or use `llvm-nm %t | FileCheck ...` to make it concise :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65882/new/

https://reviews.llvm.org/D65882