[PATCH] D65497: [RISCV] Avoid generating AssertZext for LP64 ABI when lowering floating Libcall

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

The approach seems better; I'll comment in more detail on the other review.

I'm still concerned you're not taking the time to go through the code to find all the places which need to be marked as using float arguments.



================
Comment at: lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp:133
+  default:
+    break;
+  case ISD::FADD:
----------------
unreachable?


================
Comment at: test/CodeGen/RISCV/float-fcmp.ll:7
+; RUN: llc -mtriple=riscv64 -verify-machineinstrs < %s \
+; RUN:   | FileCheck -check-prefix=RV64I %s
 
----------------
Please commit the new RUN line separately.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65497/new/

https://reviews.llvm.org/D65497