[PATCH] D64281: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 1]
Alex Brachet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 7 10:03:18 PDT 2019
abrachet marked 3 inline comments as done.
abrachet added a comment.
In D64281#1619189 <https://reviews.llvm.org/D64281#1619189>, @jhenderson wrote:
> Aargh, you pushed your latest update whilst I was doing my last review, so I can't see what are the latest changes!
>
> > added a better overload to public methods which take a SectionRef so they can be used in for-each loops.
>
> What is this bit referring to?
I added `getMutableSection(SectionRef)` and changed `getMutableSection(section_iterator Sec)` to just call that with a `*Sec`. Maybe I should remove the `section_iterator` overload though?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64281/new/
https://reviews.llvm.org/D64281
More information about the llvm-commits
mailing list