[PATCH] D64281: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 1]
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 7 08:56:48 PDT 2019
jhenderson added a comment.
Aargh, you pushed your latest update whilst I was doing my last review, so I can't see what are the latest changes!
> added a better overload to public methods which take a SectionRef so they can be used in for-each loops.
What is this bit referring to?
================
Comment at: llvm/include/llvm/Object/MutableELFObject.h:159
+ /// if (!MutSecOrErr)
+ /// handleError();
+ /// MutSecOrErr->Header.sh_addrallgin = 1;
----------------
Probably this should be handleError(MutSecOrErr.takeError());
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64281/new/
https://reviews.llvm.org/D64281
More information about the llvm-commits
mailing list