[PATCH] D65446: [yaml2obj/obj2yaml] - Add a basic support for extended section indexes.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 7 08:10:11 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one nit.



================
Comment at: test/tools/yaml2obj/elf-sht-symtab-shndx.yaml:38
+# CASE2-NEXT:   0010: 00000000 00000000 00000000 0300FFFF
+##                                                  ^-- 0xFFFF here is a SHN_XINDEX.
+# CASE2-NEXT:   0020: 00000000 00000000 00000000 00000000
----------------
This might be a Phabricator issue, but it looks like your arrow doesn't line up with the 0xFFFF?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65446/new/

https://reviews.llvm.org/D65446





More information about the llvm-commits mailing list