[PATCH] D65875: [ELF] For VS-style diagnostics, prefer using the full path.

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin created this revision.
ikudrin added reviewers: ruiu, MaskRay, chrisjackson, grimar.
ikudrin added a project: lld.
Herald added subscribers: arichardson, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

The file path we print in the message header is then used by Visual Studio to fill Error List so that a user can click on an item and jump to the mentioned location. If we use only a name part for that, Visual Studio might be unable to find the file or, even worse, show a wrong one.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D65875

Files:
  Common/ErrorHandler.cpp
  test/ELF/Inputs/vs-diagnostics-duplicate3.s
  test/ELF/vs-diagnostics-duplicate-split.s
  test/ELF/vs-diagnostics-duplicate.s
  test/ELF/vs-diagnostics-dynamic-relocation.s
  test/ELF/vs-diagnostics-undefined-hidden.s
  test/ELF/vs-diagnostics-undefined-symbol-3.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65875.213879.patch
Type: text/x-patch
Size: 5797 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190807/a2d2e9df/attachment.bin>