[PATCH] D65515: [llvm-readobj/libObject] - Introduce a custom warning handler for `ELFFile<ELFT>` methods.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/llvm-readobj/elf-wrong-shstrtab-type.test:29-31
+# AR-LLVM:  Section {
+# AR-LLVM:    Name: .shstrtab
+# AR-LLVM:    Type: SHT_PROGBITS
----------------
grimar wrote:
> jhenderson wrote:
> > Do we really need these lines for this and the following test cases? We already show that we can dump the  section as well as warn above.
> I tried to show how we dump archives with warnings. A test case below only check the messages reported,
> but here I left the full output. I think this might be worth testing. It checks that the custom warning handler
> reports messages in time, for example.
> 
> I am OK to remove it if you feel it is excessive here though.
I think it's excessive here. The timing is shown above.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65515/new/

https://reviews.llvm.org/D65515