[PATCH] D65825: [Attributor] Introduce checkForAllReadWriteInstructions(...).

[Stefan Stipanovic via Phabricator via llvm-commits]

sstefan1 marked 2 inline comments as done.
sstefan1 added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:300
+      const Function &F, const llvm::function_ref<bool(Instruction *)> &Pred,
+      AbstractAttribute &QueryingAA, InformationCache &InfoCache);
+
----------------
jdoerfert wrote:
> `bool(Instruction &)`
This will require changes in AANoSync helper functions. I'll change those as well.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:944
-    if (LivenessAA && LivenessAA->isAssumedDead(I))
-      continue;
 
----------------
jdoerfert wrote:
> It's much nice now that the concrete AAs don't need to deal with liveness and the infocache etc. but still get the benefits.
Agreed!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65825/new/

https://reviews.llvm.org/D65825