[PATCH] D65658: [InstCombine] Propagate fast math flags through selects

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 7 04:08:50 PDT 2019


foad added a comment.

In D65658#1616800 <https://reviews.llvm.org/D65658#1616800>, @spatel wrote:

> The code change seems fine, but the lone test does not provide enough coverage. Please have a look and rebase:
>  rL368028 <https://reviews.llvm.org/rL368028>


Done. Thanks for the test cases! Note that the fdiv case is not affected because `InstCombiner::visitFDiv` does not call `SimplifySelectsFeedingBinaryOp`. Perhaps it should.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65658/new/

https://reviews.llvm.org/D65658





More information about the llvm-commits mailing list