[PATCH] D64252: [Mips] Instruction `sc` now accepts symbol as an argument

[Simon Atanasyan via Phabricator via llvm-commits]

atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.

LGTM with a few nits. I will fix them by myself before committing the patch.



================
Comment at: lib/Target/Mips/MCTargetDesc/MipsTargetStreamer.cpp:348
+    MCOperand &LoOperand, unsigned ATReg, SMLoc IDLoc,
+    const MCSubtargetInfo *STI) {
+  // sc $8, sym => lui $at, %hi(sym)
----------------
clang-format


================
Comment at: lib/Target/Mips/MCTargetDesc/MipsTargetStreamer.cpp:365
+  }
+  else {
+    if (BaseReg != Mips::ZERO)
----------------
ditto


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64252/new/

https://reviews.llvm.org/D64252