[PATCH] D65736: Handle /align option.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/COFF/Writer.cpp:1201
   sizeOfHeaders = alignTo(sizeOfHeaders, config->fileAlign);
-  uint64_t rva = pageSize; // The first page is kept unmapped.
+  uint64_t rva = config->align; // The first page is kept unmapped.
   fileSize = sizeOfHeaders;
----------------
rnk wrote:
> Should this be `alignTo(sizeOfHeaders, config->align)`? I assume sizeOfHeaders was less than 4096, so this shouldn't be a behavior change for a default alignment.
Yeah, I think you are right. Fixed.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65736/new/

https://reviews.llvm.org/D65736