[PATCH] D65847: [llvm-readelf] --notes: move 'Data size' column left by 1

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 7 02:08:34 PDT 2019


MaskRay added a comment.

In D65847#1618466 <https://reviews.llvm.org/D65847#1618466>, @jhenderson wrote:

> LGTM. I assume that the 64-bit note layout (i.e. one with a 64-bit size field) works too?


binutils/readelf.c

>   printf (_("  %-20s %10s\tDescription\n"), _("Owner"), _("Data size"));

I think it is very unlikely that the size is larger than 32-bit...


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65847/new/

https://reviews.llvm.org/D65847





More information about the llvm-commits mailing list