[PATCH] D65850: GlobalISel: pack various parameters for lowerCall into a struct.

[Tim Northover via Phabricator via llvm-commits]

t.p.northover created this revision.
t.p.northover added a reviewer: aemerson.
Herald added subscribers: Petar.Avramovic, volkan, atanasyan, jrtc27, hiraditya, javed.absar, rovka, sdardis, mcrosier.
Herald added a project: LLVM.

I've now needed to add an extra parameter to this call twice recently. Not only is the signature getting extremely unwieldy, but just updating all of the callsites and implementations is a pain. Putting the parameters in a struct sidesteps both issues.


Repository:
  rL LLVM

https://reviews.llvm.org/D65850

Files:
  llvm/include/llvm/CodeGen/GlobalISel/CallLowering.h
  llvm/lib/CodeGen/GlobalISel/CallLowering.cpp
  llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
  llvm/lib/Target/AArch64/AArch64CallLowering.cpp
  llvm/lib/Target/AArch64/AArch64CallLowering.h
  llvm/lib/Target/ARM/ARMCallLowering.cpp
  llvm/lib/Target/ARM/ARMCallLowering.h
  llvm/lib/Target/Mips/MipsCallLowering.cpp
  llvm/lib/Target/Mips/MipsCallLowering.h
  llvm/lib/Target/X86/X86CallLowering.cpp
  llvm/lib/Target/X86/X86CallLowering.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65850.213813.patch
Type: text/x-patch
Size: 26367 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190807/9e865e67/attachment.bin>