[PATCH] D64825: Enable assembly output of local commons for AIX

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/MC/MCSectionXCOFF.cpp:35
+      llvm_unreachable(
+          "Unsupported storage-mapping class for common/bss csect.");
     if (getCSectType() != XCOFF::XTY_CM)
----------------
"Unsupported" is ambiguous.

This patch needs a rebase. During/after the rebase we need to figure out what the `llvm_unreachable`s should be. That is, the message text needs to clearly express the rationale so that the determination of whether `llvm_unreachable` is the appropriate mechanism can be done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64825/new/

https://reviews.llvm.org/D64825