[PATCH] D65787: [llvm-strip] Support --strip-sections with the llvm-strip command.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 6 20:31:58 PDT 2019


MaskRay added a comment.

In D65787#1617372 <https://reviews.llvm.org/D65787#1617372>, @wolfgangp wrote:

> I'm a bit unclear on what this means:
>
> > The description should be changed to state that this is a strip option, so it seems a good fit for llvm-strip. We already have --strip-all --strip-all-gnu --strip-debug --strip-unneeded --strip-symbol so it seems natural to have another `--strip-*`.
>
> What description should be changed? The help text? Right now I see few distinctions between the 2 invocations in the *.td files for objcopy and strip respectively.


This sentence in the description:

> The reasons for this are unclear, so this patch adds the option to llvm-strip.

We do not add options merely for "unclear" reasons. It is because the option is a good fit for llvm-strip.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65787/new/

https://reviews.llvm.org/D65787





More information about the llvm-commits mailing list