[PATCH] D65242: [ELF] More dynamic relocation packing
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 6 19:16:14 PDT 2019
MaskRay added a comment.
> Would it be simpler to only support an addend of 0 here? I reckon that non-zero addends are rare enough that we can just let them be emitted in ungroupedNonRelatives.
I'd like @pcc's comment to be addressed. The three relocation types `R_*_JUMP_SLOT, R_*_GLOB_DAT, R_*_COPY` always have 0 r_addend. A symbolic relocation (`R_AARCH64_ABS64, R_X86_64_64`, etc) may have non-zero r_addend but they are rare. Non-relative relocation with non-zero r_addend can just be placed in `ungroupedNonRelatives`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65242/new/
https://reviews.llvm.org/D65242
More information about the llvm-commits
mailing list