[PATCH] D65684: [WebAssembly] Lower ASan constructor priority on Emscripten

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:132
 static const uint64_t kAsanCtorAndDtorPriority = 1;
+static const uint64_t kAsanEmscriptenCtorAndDtorPriority = 50;
 static const char *const kAsanReportErrorTemplate = "__asan_report_";
----------------
quantum wrote:
> sbc100 wrote:
> > Any reason not to change this for all platforms?  In any case an explaining comment might be a good idea here.
> I suspect doing that will break things on other platforms. I shall add a comment.
I think it might be a good idea to contact the original author to find out why 1 was chosen here and if they think it would be OK to change to 50 across the board.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65684/new/

https://reviews.llvm.org/D65684