[PATCH] D65793: [UpdateTestChecks] Update tests option

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 6 13:57:48 PDT 2019


xbolva00 marked 2 inline comments as done.
xbolva00 added inline comments.


================
Comment at: utils/UpdateTestChecks/common.py:297
+
+def is_autogenerated_test_file(input_lines):
+  return len(input_lines) > 0 and 'autogenerated' in input_lines[0]
----------------
xbolva00 wrote:
> MaskRay wrote:
> > I don't know if a common function is useful, ideally an `update*.py` utility should abort if the test file was generated by another `update*.py` utility, e.g.
> > 
> > `update_llc_test_checks.py` should abort if the file was generated by `update_test_checks.py`.
> > 
> Yes, such checker would be useful addition. I will do it.
Done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65793/new/

https://reviews.llvm.org/D65793





More information about the llvm-commits mailing list