[PATCH] D65686: IR: Disable verifier check for GlobalValues with private linkage named after a comdat for non-COFF.
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 6 11:45:48 PDT 2019
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
In the past, Rafael advocated for having more verifier check more things that are unrepresentable at an object file level. That's how we ended up with most of the checks in Verifier::visitGlobalAlias. I think this is consistent with that, even if we have to check which object file invariant we're enforcing.
lgtm
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65686/new/
https://reviews.llvm.org/D65686
More information about the llvm-commits
mailing list