[PATCH] D65736: Handle /align option.

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm with question, no need to re-review



================
Comment at: lld/COFF/Writer.cpp:1201
   sizeOfHeaders = alignTo(sizeOfHeaders, config->fileAlign);
-  uint64_t rva = pageSize; // The first page is kept unmapped.
+  uint64_t rva = config->align; // The first page is kept unmapped.
   fileSize = sizeOfHeaders;
----------------
Should this be `alignTo(sizeOfHeaders, config->align)`? I assume sizeOfHeaders was less than 4096, so this shouldn't be a behavior change for a default alignment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65736/new/

https://reviews.llvm.org/D65736